Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blocked regression logistic, use casewise functions from lin reg #301

Merged
merged 3 commits into from
Apr 24, 2024
Merged

blocked regression logistic, use casewise functions from lin reg #301

merged 3 commits into from
Apr 24, 2024

Conversation

JohnnyDoorn
Copy link
Contributor

@JohnnyDoorn
Copy link
Contributor Author

Unit tests changes:
add helper function to include qml from common
coefficients table includes output for each model, so those are expanded
casewise table is replaced with same table as for other regressions, std residual is now deviance instead of pearson

Kucharssim
Kucharssim approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@Kucharssim Kucharssim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look ok to me, I did not test it in JASP though!

@JohnnyDoorn
Copy link
Contributor Author

Awesome, thanks @Kucharssim. I can merge it, and then others (maybe @tomtomme?) can test it in the nightly

@JohnnyDoorn JohnnyDoorn merged commit a82bd4a into jasp-stats:master Apr 24, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kucharssim Kucharssim Kucharssim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Hierarchical logistic regression (entering predictors in blocks)
2 participants
@JohnnyDoorn @Kucharssim